Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix TinyMCE media button, frontend edit #43376

Merged
merged 3 commits into from
May 11, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 26, 2024

Pull Request for Issue #43344 .

Summary of Changes

Fix the Media button for frontend, in submenu.

Testing Instructions

Please follow #43344

Actual result BEFORE applying this Pull Request

Broken

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 30936e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43376.

1 similar comment
@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 30936e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43376.

@Quy
Copy link
Contributor

Quy commented Apr 27, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43376.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 27, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.1 milestone May 11, 2024
@LadySolveig LadySolveig merged commit 08316bb into joomla:5.1-dev May 11, 2024
2 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @Fedik and for testing @brianteeman @carlitorweb

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@Fedik Fedik deleted the fix-43344 branch May 11, 2024 15:27
@Scrabble96
Copy link
Contributor

I'm using 5.1.0 and have this problem but it is solved (on a test site) with Joomla_5.1.1-rc1-Release_Candidate-Update_Package - EXCEPT that when a front-end user first clicks on the CMS media link the pop-up window contains the message "You have been logged out". This is not true, as the user can continue editing and saving articles. I am using a custom template; not Cassiopeia. The html is:

   <div class="alert-wrapper">
     <div class="alert-message">You have been logged out.</div>
   </div>

@brianteeman
Copy link
Contributor

Please do not comment on closed issues or pull requests. Very few people will see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Manager is wrongly initialised by TinyMCE when accessed from a front-end submenu item
7 participants