Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include MariaDB and remove SQL Server in README (.txt and .md) #43368

Merged
merged 6 commits into from
May 20, 2024

Conversation

robertsilen
Copy link

Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (#43343). There is a separate PR for the .md version of the README.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README should include MariaDB too.
Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (joomla#43343). There is a separate PR for the .md version of the README.
@Quy
Copy link
Contributor

Quy commented Apr 25, 2024

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

@robertsilen
Copy link
Author

robertsilen commented Apr 25, 2024

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Do you want me to merge this with the PR for README.md? Not sure how to do that.

@Quy
Copy link
Contributor

Quy commented Apr 25, 2024

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

@robertsilen robertsilen changed the title Update README.txt to include MariaDB (.txt, not .md) Update README.txt to include MariaDB (.txt and .md) Apr 26, 2024
@robertsilen robertsilen changed the title Update README.txt to include MariaDB (.txt and .md) Update README to include MariaDB (.txt and .md) Apr 26, 2024
@robertsilen robertsilen changed the title Update README to include MariaDB (.txt and .md) Update to include MariaDB and remove SQL Server in README (.txt and .md) Apr 26, 2024
@robertsilen
Copy link
Author

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

This PR for 5.5 includes MariaDB and SQL Server modifications to README.txt and README.md now. For 4.4 version there is this PR.

@Quy
Copy link
Contributor

Quy commented May 7, 2024

I have tested this item ✅ successfully on 1205699


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1205699


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

@Quy
Copy link
Contributor

Quy commented May 17, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 17, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.1 milestone May 20, 2024
@LadySolveig LadySolveig merged commit de6e9ad into joomla:5.1-dev May 20, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 20, 2024
@LadySolveig
Copy link
Contributor

Thank you @robertsilen and for review @Quy @viocassel

@robertsilen robertsilen deleted the patch-4 branch June 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants