-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to include MariaDB and remove SQL Server in README (.txt and .md) #43368
Conversation
Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README should include MariaDB too.
Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (joomla#43343). There is a separate PR for the .md version of the README.
Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks. |
I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this? Do you want me to merge this with the PR for README.md? Not sure how to do that. |
Commented in the other PR.
Switch to patch-4 branch. Apply the change from the other branch. |
merging change to README .txt and .md
This PR for 5.5 includes MariaDB and SQL Server modifications to README.txt and README.md now. For 4.4 version there is this PR. |
I have tested this item ✅ successfully on 1205699 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368. |
1 similar comment
I have tested this item ✅ successfully on 1205699 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368. |
Thank you @robertsilen and for review @Quy @viocassel |
Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (#43343). There is a separate PR for the .md version of the README.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed