Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Adminmenu: Toggle for duplicate menus #43308

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Apr 18, 2024

Pull Request for Issue #32934 .

Summary of Changes

Same as the 4.4-dev PR #43192 , but this here is for 5.1-dev.

As the modified file has been refactored in the 5.1-dev branch with PR #42784 , the change from PR #43192 cannot be merged up from 4.4-dev into 5.1-dev as it is.

Therefore I've created this PR here which does the same change as PR #43192 but at a different place due to the refactoring.

Testing Instructions

See #43192 :

  1. Create a second menu module in the administrator, assign it to the menu position and select the "Joomla Main Menu" preset for the module.
  2. Click on the toggle button to close the sidebar.
  3. Click on the "Content" menu item in the second module.

Actual result BEFORE applying this Pull Request

The sidebar stays closed.

Expected result AFTER applying this Pull Request

The sidebar opens, like for the menu entries in the first menu module.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Apr 18, 2024
@richard67 richard67 added the bug label Apr 18, 2024
@exlemor
Copy link

exlemor commented Apr 20, 2024

I have tested this item ✅ successfully on 5c58018

Hi Richard,

I was able to test this successfully. :)

Thanks for your hard work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.

@fgsw
Copy link

fgsw commented Apr 20, 2024

I have tested this item ✅ successfully on 5c58018


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.

@Quy
Copy link
Contributor

Quy commented Apr 20, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 20, 2024
@bembelimen bembelimen merged commit 26a740f into joomla:5.1-dev May 11, 2024
2 of 3 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.1 milestone May 11, 2024
@richard67 richard67 deleted the 5.1-dev-fix-adminmenu-toggle-for-multiple-menus branch May 11, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants