-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Fix comment syntax in update SQL scripts "5.1.0-2024-02-24.sql" for adding TUF #43306
[5.1] Fix comment syntax in update SQL scripts "5.1.0-2024-02-24.sql" for adding TUF #43306
Conversation
Hi @richard67, I must be doing something wrong because whether the patch is Applied or Not: If I use the Import feature in phpmyadmin, the 5.1.0-2024-02-24.sql is successfully upload/merged/imported without errors. If I use the SQL queries window, I get an error as long as the comment blocks are there whether the patch is Applied or Not, MySQL 8.0.36. (sorry) :( |
@exlemor Update: No, the PR is ok. |
@exlemor As my instructions say you should use the SQL input window, not the import. What I've forgotten to mention is that it needs to replace the It does not really need to apply the PR for testing. It is enough to copy the original SQL from the unmodified file in the 5.1-dev branch and from the modified SQL file from this PR here by going to the files on GitHub. |
I have tested this item ✅ successfully on 2b1c2af
|
I have tested this item ✅ successfully on 2b1c2af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43306. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43306. |
Pull Request for Issue #43302 .
Summary of Changes
This pull request (PR) fixes the syntax error in the SQL code comment in the update SQL scripts "5.1.0-2024-02-24.sql" mentioned in the referred issue.
Note that the SQL syntax error will never happen when updating Joomla to 5.1.x as the updater splits the SQL script into the single statements, stripping off any comments (also those with the syntax error), and runs these statements one by one. The error happens only if you copy the content of the script into an SQL client to run the statements "manually", e.g. when trying to fix an update which failed for other reasons.
Testing Instructions
Code review.
Or if you want to do a real test: Depending on which database type you have available for testing (MySQL/MariaDB or Postgresql), copy the content of the update SQL script "5.1.0-2024-02-24.sql" into an SQL client, e.g. phpMyAdmin for MySQL/MariaDB or phpPgAdmin for PostgreSQL, replace the
#__
by your real table name prefix and run the SQL statement.Actual result BEFORE applying this Pull Request
See issue #43302 .
Expected result AFTER applying this Pull Request
No SQL syntax error with that comment.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed