-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Add missing Toggle inline help button to plugin modal / dialog #43296
Conversation
I have tested this item 🔴 unsuccessfully on 9ed546c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296. |
1 similar comment
I have tested this item 🔴 unsuccessfully on 9ed546c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296. |
Are you sure that is a good test instruction. That plugin doesnt show the toggle inline help button in a normal view either |
I have tested this item ✅ successfully on 9ed546c Please provide better testing instructions!! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296. |
@brianteeman How did you test? Which plugin? |
i edited the code so that I could test the sef plugin |
Sorry everybody, instructions updated. Toggle inline Help button is hidden when there are no descriptions in the XML file. I have added a step to add a description to the redirect plugin. Hope this makes it clear. Sorry for the confusion! |
I have tested this item ✅ successfully on 9ed546c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296. |
Thanks for testing everybody! Appreciate you taking the time for it. |
Thank you for this great idea! |
What other components? |
Sorry I must have confused this PR with another one as I was sure I had seen changed across all modals |
Pull Request for Issue #43289 (comment) .
Summary of Changes
plugin modal was missing Toggle inline help button
Testing Instructions
a. add a description to a field in the file ./plugins/system/redirect/redirect.xml
e.g. to this field:
(line 6: description = has been added)
disable the system redirect plugin
![image](https://private-user-images.githubusercontent.com/2733197/324085772-d1b7c164-a158-4de2-9c12-c5ef66fee919.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTgyNjQsIm5iZiI6MTcyMzA1Nzk2NCwicGF0aCI6Ii8yNzMzMTk3LzMyNDA4NTc3Mi1kMWI3YzE2NC1hMTU4LTRkZTItOWMxMi1jNWVmNjZmZWU5MTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkxMjQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTU0MzQ3YzNmZGViMDM5ZWZlN2ZlOWZkMzU0Y2Y0MDNiMGMxNjQ3MWIzM2VmMTZjMGMwZTZlMWJkMGU0MDM1OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.SmhR3V-uthPbCzdfxHOMH-a0d1jVsb2PCoDsMy8PImk)
goto com_redirect
in the alert telling you that the system redirect plugin is disabled, click on the link > the plugin will open in a modal
![image](https://private-user-images.githubusercontent.com/2733197/324085868-2b8aa3df-b4d3-4268-be95-95790565811c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTgyNjQsIm5iZiI6MTcyMzA1Nzk2NCwicGF0aCI6Ii8yNzMzMTk3LzMyNDA4NTg2OC0yYjhhYTNkZi1iNGQzLTQyNjgtYmU5NS05NTc5MDU2NTgxMWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkxMjQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjRmZGY3YzcxNmIwMzBmZDZlNDI3NzI5YjQ5NmViMjg3YzIyMGRhMDZjMTcyZjY3MzU0MjllYTJkNWY2MzYzNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.5VAeQ-1Ts5hprNZplo5y_Rtq5qVmlHsFKpX72dlfcTk)
Actual result BEFORE applying this Pull Request
The modal had three buttons: Save, Save & Close and Close
![image](https://private-user-images.githubusercontent.com/2733197/324085976-89c19a38-da85-4d9f-859d-dc4c06e85a49.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTgyNjQsIm5iZiI6MTcyMzA1Nzk2NCwicGF0aCI6Ii8yNzMzMTk3LzMyNDA4NTk3Ni04OWMxOWEzOC1kYTg1LTRkOWYtODU5ZC1kYzRjMDZlODVhNDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkxMjQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjU1OWEwNDYwZDg3ODE2ZGViMDM5MzNhZDA0YmQzYzM5YjAwZjA0NzQ0ZDFiNDY1Y2UyOTk5ZGM2MWE0MTNhMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.zhtpG6V8Zyzat4uo84kahHep82g7UpNTbelw55NwzlU)
Expected result AFTER applying this Pull Request
The modal has 4 buttons: Save, Save & Close, Close and Toggle inline help
![image](https://private-user-images.githubusercontent.com/2733197/324086068-997aa66e-67f3-443a-8591-4076e0b6a280.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNTgyNjQsIm5iZiI6MTcyMzA1Nzk2NCwicGF0aCI6Ii8yNzMzMTk3LzMyNDA4NjA2OC05OTdhYTY2ZS02N2YzLTQ0M2EtODU5MS00MDc2ZTBiNmEyODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTkxMjQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmZkNzY0ZmJlOGRiYmJjZjJhYWIxMmNkM2YyOWFmMzZlMTljZjM3OGVkN2RlODc2NzZjN2ZmZjEzMDcyZTEzNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rpl5pgo4zSu5Y-N7IvpVDZKjm0PQkojPNZI8b_ZgL9Y)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed