[5.1] Add backward compatibility for older Plugin/Module bootstrap modals #43291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43289 .
Summary of Changes
The PR add a backward compatibility code to handle buttons for bootstrap modal for Plugin/Module editing.
Testing Instructions
Run
npm install
.Add following code, somewhere, example in to index.php of Admin template:
It will render bootstrap modal, and link that opens it.
Then click this link, and in the opened modal try to edit any field, and use modal's buttons to save .
Actual result BEFORE applying this Pull Request
Nothing happens (when click "save"), modal just closes (when click "close" or "save and close").
Expected result AFTER applying this Pull Request
The form saved, the modal closes after it.
Link to documentations
Please select:
References: