Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] plugins\filesystem\local\src\Adapter\LocalAdapter.php #43274

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Spotted this code style issue while working on something else. Might as well fix it.
Code review only

Maintainers can decide which branch to merge it into

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Apr 14, 2024

I have tested this item ✅ successfully on 1ad9f6f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43274.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Apr 14, 2024

I have tested this item ✅ successfully on 1ad9f6f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43274.

@alikon
Copy link
Contributor

alikon commented Apr 14, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43274.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 14, 2024
@brianteeman
Copy link
Contributor Author

sorry I found another one in the same file please retest

@alikon
Copy link
Contributor

alikon commented Apr 14, 2024

I have tested this item ✅ successfully on 29fc372


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43274.

@alikon alikon removed the RTC This Pull Request is Ready To Commit label Apr 14, 2024
@Quy Quy added the RTC This Pull Request is Ready To Commit label Apr 16, 2024
@HLeithner HLeithner added the bug label Apr 24, 2024
@MacJoom MacJoom self-assigned this Apr 26, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone Apr 26, 2024
@MacJoom MacJoom merged commit 079047c into joomla:4.4-dev Apr 26, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 26, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Apr 26, 2024

Thank you!

@brianteeman brianteeman deleted the patch-3 branch June 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants