Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] json encoded in bind method #43273

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Spotted whilst working elsewhere and struggled to understand the code comment as the description was confising.

This simple PR corrects the grammar so that it is more understandable

Code review only required as its a doc block

Comment

Maintainers can decide the best branch

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Spotted whilst working elsewhere and struggled to understand the code comment as the description was confising.

This simple PR corrects the grammar so that it is more understandable

Code review only required as its a doc block
@richard67
Copy link
Member

I have tested this item ✅ successfully on 1e67d58

Tested by review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43273.

@Quy
Copy link
Contributor

Quy commented Apr 14, 2024

I have tested this item ✅ successfully on 1e67d58


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43273.

@Quy
Copy link
Contributor

Quy commented Apr 14, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43273.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 14, 2024
@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:06
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] json encoded in bind method [5.2] json encoded in bind method Apr 24, 2024
@pe7er pe7er merged commit 1ca6a70 into joomla:5.2-dev Apr 30, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 30, 2024
@pe7er
Copy link
Contributor

pe7er commented Apr 30, 2024

Thanks @brianteeman !

@Quy Quy removed the PR-5.1-dev label Apr 30, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Apr 30, 2024
@brianteeman brianteeman deleted the bind_docblock branch May 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants