Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Removing deprecated access to User object attributes #43268

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 12, 2024

Summary of Changes

This PR removes almost all cases where we are accessing attributes of the user object through the deprecated CMSObject::get() method. All these can be replaced by simply accessing the attribute directly. This change is based on a check with phpstan.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sandewt
Copy link
Contributor

sandewt commented Apr 15, 2024

I have tested this item ✅ successfully on eefbe1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43268.

@pe7er pe7er self-assigned this Apr 18, 2024
@pe7er pe7er merged commit a7f5e50 into joomla:5.2-dev Apr 30, 2024
3 checks passed
@pe7er
Copy link
Contributor

pe7er commented Apr 30, 2024

Thanks @Hackwar !

@Quy Quy added this to the Joomla! 5.2.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants