Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Backendmenu: Fixing import of presets for menu items (ajaxbadge, ...) #43189

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 1, 2024

Summary of Changes

When importing a backend menu preset into a backend menu, the information for dashboard elements and ajax badges gets lost.

Testing Instructions

  1. Go to menu manager and filter by admin
  2. create a new menu and select "Preset - Joomla Main Menu" as preset and save.
  3. Create a module for the menu and set it to position "menu"

Actual result BEFORE applying this Pull Request

The second backend menu is missing both dashboard and potential ajax badge icons. (The Main Menu preset doesn't have an ajax badge)

Expected result AFTER applying this Pull Request

The dashboard icons show up.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Apr 3, 2024

Perhaps I didn't understand the description but for me, nothing seems to have changed before or after having applied the Patch

1st without patch 43189 applied:

without-patch-43189-applied

FYI: after seeing that the 2nd [test menu] was Access: Public, I also tried it with Access: Special and that did not change the after patch 43189 applied results.

2nd with patch 43189 applied:
with-patch-43189-applied

@Hackwar what did I miss?

@Hackwar
Copy link
Member Author

Hackwar commented Apr 8, 2024

Did you import the menu items before or after applying the patch? If you imported the preset before applying the patch, that is exactly the issue this PR is trying to fix: The import (which creates a bunch of menu items in the database) does not take care of the additional features. Applying the patch afterwards doesn't change the data which has been written to the database.

@akshehu
Copy link

akshehu commented Apr 11, 2024

For me, all seem to work well after following the process and testing. All good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.

@akshehu
Copy link

akshehu commented Apr 11, 2024

I have tested this item ✅ successfully on 344dff5

For me, all seem to work well after following the process and testing. All good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 344dff5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.

@Quy
Copy link
Contributor

Quy commented Apr 15, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43189.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2024
@MacJoom MacJoom merged commit 26234f6 into joomla:4.4-dev Apr 27, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 27, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone Apr 27, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Apr 27, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants