Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix for legacy editor-xtd plugins with array of buttons #43129

Merged
merged 2 commits into from
May 11, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Mar 23, 2024

Pull Request for Issue #43128 .

Summary of Changes

Fix compatibility with legacy editor-xtd plugins, which return multiple buttons.

Testing Instructions

Edit

And replace whole method with:

public function onDisplay($name)
{
  return [
    new CMSObject([
        'action'  => 'insert',
        'icon'    => 'foobar',
        'text'    => 'Beer',
        'options' => ['content' => '🍺 ']
    ]),
    new CMSObject([
        'action'  => 'insert',
        'icon'    => 'foobar',
        'text'    => 'Cat',
        'options' => ['content' => '🐈 ']
    ]),
  ];
}

Go to content editing. And check for this button.

Actual result BEFORE applying this Pull Request

Only Cat button is shown.

Expected result AFTER applying this Pull Request

Both buttons is shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added bug Small A PR which only has a small change labels Mar 23, 2024
@Tazzios
Copy link

Tazzios commented Mar 23, 2024

I have tested this item ✅ successfully on 07ebef5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 07ebef5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

@Quy Quy removed the Small A PR which only has a small change label Mar 23, 2024
@Quy
Copy link
Contributor

Quy commented Mar 23, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 23, 2024
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev April 24, 2024 09:13
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the title [5.0] Fix for legacy editor-xtd plugins with array of buttons [5.1] Fix for legacy editor-xtd plugins with array of buttons Apr 24, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.1 milestone May 11, 2024
@LadySolveig LadySolveig merged commit 9838498 into joomla:5.1-dev May 11, 2024
2 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @Fedik and for testing @Tazzios and @viocassel

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@Fedik Fedik deleted the fix-43128 branch May 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants