-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] CodeMirror 6 Javascript highlighting not working #43114
Conversation
I have tested this item ✅ successfully on d54448f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114. |
I have tested this item ✅ successfully on d54448f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114. |
It is working after applying the patch. |
Thank you for testing - please go to https://issues.joomla.org/tracker/joomla-cms/43114 and record your test there |
I have tested this item ✅ successfully on d54448f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114. |
This pull request has been automatically rebased to 5.1-dev. |
Thank you @OctavianC and for the tests @Fedik @viocassel and @Linkedla ! |
Pull Request for Issue #43113 .
Summary of Changes
Added an alias for 'js' so that CodeMirror understands what language package to load.
Testing Instructions
See issue #43113
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed