Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] CodeMirror 6 Javascript highlighting not working #43114

Merged
merged 2 commits into from
May 11, 2024

Conversation

OctavianC
Copy link
Contributor

Pull Request for Issue #43113 .

Summary of Changes

Added an alias for 'js' so that CodeMirror understands what language package to load.

Testing Instructions

See issue #43113

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik
Copy link
Member

Fedik commented Mar 22, 2024

I have tested this item ✅ successfully on d54448f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

@Fedik Fedik added the bug label Mar 22, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on d54448f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

@alikon
Copy link
Contributor

alikon commented Mar 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 22, 2024
@Linkedla
Copy link

image

It is working after applying the patch.
Applied Commit SHA: d54448f

@brianteeman
Copy link
Contributor

Thank you for testing - please go to https://issues.joomla.org/tracker/joomla-cms/43114 and record your test there

@Linkedla
Copy link

I have tested this item ✅ successfully on d54448f

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev April 24, 2024 09:13
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the title CodeMirror 6 Javascript highlighting not working [5.1] CodeMirror 6 Javascript highlighting not working Apr 24, 2024
@LadySolveig
Copy link
Contributor

Thank you @OctavianC and for the tests @Fedik @viocassel and @Linkedla !

@LadySolveig LadySolveig merged commit 7706b3d into joomla:5.1-dev May 11, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@Quy Quy added this to the Joomla! 5.1.1 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants