Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Missing checkbox/radio and select types constants in array #43064

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

obuisard
Copy link
Contributor

Summary of Changes

This PR just adds the missing constant types in the component that have been added by PR #40994.

Testing Instructions

Just a code review is necessary, the missing types do not affect anything.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@obuisard obuisard changed the title Missing checkbox/radio and select types constants in array [5.1] Missing checkbox/radio and select types constants in array Mar 17, 2024
@Quy
Copy link
Contributor

Quy commented Mar 17, 2024

I have tested this item ✅ successfully on 30cfc39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43064.

1 similar comment
@bembelimen
Copy link
Contributor

I have tested this item ✅ successfully on 30cfc39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43064.

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 18, 2024
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Mar 18, 2024
@Quy
Copy link
Contributor

Quy commented Mar 18, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43064.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 18, 2024
@LadySolveig LadySolveig merged commit 9aaef97 into joomla:5.1-dev Mar 18, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 18, 2024
@LadySolveig
Copy link
Contributor

Thank you @obuisard ❤️ and also for testing @Quy @bembelimen

@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants