[5.1] Dialog: aria-label for Close button is not translated #43058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42301 .
Summary of Changes
Changes hadr coded english to a translatable string wioth fallback
Testing Instructions
npm run build:js
or use a prebuilt packageEnable Debug Language.
Edit an article.
Under Publishing tab > Created by, click user icon to display the modal dialog.
Using Web Developer Tools, select the Close button to inspect it.
Actual result BEFORE applying this Pull Request
aria-label="**Close**"
Expected result AFTER applying this Pull Request
<button type="button" aria-label="Close" class="button-close btn-close" data-button-close=""></button>
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed