Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Dialog: aria-label for Close button is not translated #43058

Merged
merged 5 commits into from
Mar 17, 2024

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #42301 .

Summary of Changes

Changes hadr coded english to a translatable string wioth fallback

Testing Instructions

npm run build:js or use a prebuilt package

Enable Debug Language.
Edit an article.
Under Publishing tab > Created by, click user icon to display the modal dialog.
Using Web Developer Tools, select the Close button to inspect it.

Actual result BEFORE applying this Pull Request

aria-label="**Close**"

Expected result AFTER applying this Pull Request

<button type="button" aria-label="Close" class="button-close btn-close" data-button-close=""></button>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Mar 16, 2024

I have tested this item ✅ successfully on 28ab937


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6bef5cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.

@Quy Quy changed the title [5.1] Dialog: aria-label for Close button is not translated [5.1] Dialog: aria-label for Close button is not translated Mar 16, 2024
@Quy
Copy link
Contributor

Quy commented Mar 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 17, 2024
@bembelimen bembelimen merged commit fba4f99 into joomla:5.1-dev Mar 17, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2024
@bembelimen
Copy link
Contributor

Thx

@brianteeman brianteeman deleted the publich_close branch March 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants