-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Update TourTable.php to allow save on tours #43031
Conversation
Column autostart set to 0 if null
would it not be better to update the sql instead? |
The database already defaults autostart to 0. |
yes but you could also set it to allow null couldnt you and then you dont need this temporary code? |
Oh I see what you mean... It felt 'safer' this way so I don't mess with the database again and add extra files. |
I have tested this item ✅ successfully on cf6cbc2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031. |
administrator/components/com_guidedtours/src/Table/TourTable.php
Outdated
Show resolved
Hide resolved
Added @todo
administrator/components/com_guidedtours/src/Table/TourTable.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
administrator/components/com_guidedtours/src/Table/TourTable.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 1bef0eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031. |
1 similar comment
I have tested this item ✅ successfully on 1bef0eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031. |
Thx |
Summary of Changes
Since the introduction of the welcome tour, the addition of the autostart column fails the saving of tours.
Testing Instructions
Go to System -> Guided Tours, create a tour and save.
Try also 'duplicate' and 'save as copy'.
Actual result BEFORE applying this Pull Request
Error 'Save failed with the following error: Column 'autostart' cannot be null'.
Expected result AFTER applying this Pull Request
No error on save.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed