[4.4] Vote : aggregateRating error in Google Rich Results

[conseilgouz]

( see discussion #42920) and #42933

Summary of Changes

When vote plugin is enabled, Rich results are created but are rejected by Google Rich Results tool.

Testing Instructions

Enable Vote plugin.
Enable Voting in Articles component configuration.
Vote for one or more articles.
Check your article using https://search.google.com/test/rich-results

Actual result BEFORE applying this Pull Request

Google Rich Results check gives an error
Review snippets shows 2 errors :

Expected result AFTER applying this Pull Request

Google Rich Results check is OK

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[conseilgouz]

@sandewt PR moved to 4.4 branch.
Please test https://issues.joomla.org/tracker/joomla-cms/42934

[ManuelVoileux]

I have tested this item ✅ successfully on 2f594e4

I have experienced the same issue.
I have activated the Vote plugin, and I have used vote on an article.
When I check with the Google validation tool I get a critical error. itemReviewed field missing.

AFTER applying this Pull Request I got green light from Google

As Fedik mentionned Add the layout with Schema plugin so that no additionnal shema type (such as Product) is involved

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.}

[fgsw]

I have tested this item ✅ successfully on 2f594e4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.}

[conseilgouz]

As Fedik mentionned Add the layout with Schema plugin so that no additionnal shema type (such as Product) is involved

Schema plugins have been introduced in Joomla 5.0 and this PR is due to work with Joomla 4.4.

[ManuelVoileux]

You are right, sorry for the mistake.
What is the appropriate process to have a J5 branch to solve this bug ?

[conseilgouz]

You are right, sorry for the mistake. What is the appropriate process to have a J5 branch to solve this bug ?

It will be to move aggregatingRating into schema plugins, as each schema type has its own required fields list.

[sandewt]

for your information: Schema.org Product type plugin #42710

[conseilgouz]

for your information: Schema.org Product type plugin #42710

Thank you for this information.

This PR is trying to fix an issue in vote plugin, it's not to create a schemaorg product plugin.

As stated in #42933 , I found we could make aggregateRating work by using product type.

In J5, I think we'll have to fix it another way, maybe through existing schemaorg plugins.

[sandewt]

Review versus Product ?

see #42933 (comment)

[Fedik]

Sorry, the changes still incorrect. We should not force any itemscope in to the rating layout,
It can be rendered as part of already defined itemscope. User can already have Article layout override with custom itemscope. This changes will break his schema.

In the end, this hack replaces one problem to another.

For proper fix check the coments in PR for 5.1 (#42933 (comment))

[conseilgouz]

Review versus Product ?

see #42933 (comment)

Review requires a single user, rating count will disappear.

[conseilgouz]

For proper fix check the coments in PR for 5.1

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

I have a doubt on where to implement this.

For example, for Recipe, I added some lines into plugins/schema/recipe/src/Extension/Recipe.php so it added Recipe dedicated rating lines to the Recipe information. I created a new class SchemaorgPrepareRecipeAggregateRating in libraries/src/Schemaorg.

Does it sound correct or is there a better place to add this, using isPartOf maybe ?

[sandewt]

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

Sorry, but I think it's better to focus on J4 here and not J5.

[Fedik]

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

In theory the voting plugin should listen to onSchemaBeforeCompileHead and apend the rating data.

[bembelimen]

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

In theory the voting plugin should listen to onSchemaBeforeCompileHead and apend the rating data.

Exactly that

[exlemor]

I have tested this item ✅ successfully on 07d5eed

Hi @conseilgouz, I just tested this successfully just now.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.}

[conseilgouz]

Hi Emmanuel,
Thank you for your test.
For this PR, there already were 2 human tests by @fgsw and @ManuelVoileux, but they disappeared from the counter.

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.}

[MacJoom]

Thank you!

[sandewt]

Sorry but this PR is not correct because the Number of Votes will never be visible.
Because the class is: class="visually-hidden".

Solution move the closing </div