Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Smart Search, limit the highlight #42921

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Feb 29, 2024

Pull Request for Issue #42889

Summary of Changes

Same as #41463 but for highlight plugin

Testing Instructions

In testing installation.
In Smart Search config set "Word Match" to "Match words containing the search term anywhere".
Go to search page, and search for joomla 1.
Notice the length of the link for each search result.

Actual result BEFORE applying this Pull Request

it is long

Expected result AFTER applying this Pull Request

it is shorter

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@ceford
Copy link
Contributor

ceford commented Feb 29, 2024

I have tested this item ✅ successfully on 84c7fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 84c7fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

@Quy
Copy link
Contributor

Quy commented Feb 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Mar 1, 2024

Sorry, but we have this already in the layout of smart search. https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_finder/tmpl/search/default_results.php#L64

I don't think it is useful to duplicate this code here as well.

@Fedik
Copy link
Member Author

Fedik commented Mar 1, 2024

@Hackwar nope, it is diferent, it is for URL. What is in your PR is for JavaScript.

@laoneo laoneo added RMDQ ReleaseManagerDecisionQueue and removed RMDQ ReleaseManagerDecisionQueue labels Mar 4, 2024
@laoneo laoneo merged commit f8c67be into joomla:4.4-dev Mar 4, 2024
4 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 4, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 4, 2024
@laoneo laoneo added this to the Joomla! 4.4.4 milestone Mar 4, 2024
@Fedik Fedik deleted the highlight-limit branch March 4, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants