[5.2] Static function getList deprecated in mod_stats

[joomlaweby]

Summary of Changes

Static function getList is after applying pull request deprecated and new non-static method getStats created in StatsHelper.

Testing Instructions

1. Make sure you have site module mod_stats published
2. You should see module output on frontend
3. Deprecated static function getList should also work

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[fgsw]

After click on Apply Patch in Patchtester only a red Message is shown: "The file marked for modification does not exist: modules/mod_stats/src/Dispatcher/Dispatcher.php".

[brianteeman]

@fgsw Your local joomla installation is not up to date

[fgsw]

My Installation Setting:

Better to down- and upload & install every day the nightly build (now Joomla_5.1.0-beta1-dev-Development-Update_Package.zip)?

[fgsw]

I have tested this item ✅ successfully on 15ba980

Using nightly build.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[ceford]

Just realised I am testing with PHP8.3 - everything seems to work. For this PR I do not see a deprecated notice with or without the patch. Am I supposed to?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[joomlaweby]

Just realised I am testing with PHP8.3 - everything seems to work. For this PR I do not see a deprecated notice with or without the patch. Am I supposed to?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.

@ceford No, deprecated static function in helper file may be still used by other extensions (probably only 3rd party), so this is the case, when this deprecated function is called. Module mod_stats is now using new non-static method from helper, so there is no deprecation notice.

[ceford]

I have tested this item ✅ successfully on 15ba980

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[richard67]

Back to pending as there have been made changes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[exlemor]

I have tested this item ✅ successfully on 1dbe39e

Was successful and noticed that in Joomla Debug, there seems to be fewer Queries after Patch.

Before Patch: 28 statements were executed, 6 of which were duplicates, 22 unique
After Patch: 25 statements were executed, 2 of which were duplicates, 23 unique

so if intended great and even if not, fewer = better so great :)

Thanks for yet another good fix.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[viocassel]

I have tested this item ✅ successfully on 1dbe39e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[cybersalt]

I have tested this item ✅ successfully on 1dbe39e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.}

[brianteeman]

great to see all these tests @cybersalt - hope this will become a regular thing

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[pe7er]

Thanks @joomlaweby !