[5.2] Fix of unnecessary SQL query for Fields, get the field value already loaded by getFields()

[Fedik]

Summary of Changes

Remove unnecessary SQL query for the custom fields, during the form rendering.
FieldsHelper::getFields() load the field value, however FieldsHelper::prepareForm() also loading them wthout a reason.
Also removed some dead code.

Testing Instructions

Enable debug and debug query.
Create a couple of Custom fields, let say 10.
Open article editing.

Actual result BEFORE applying this Pull Request

Notice amount of query in debug.
Let say 75

Expected result AFTER applying this Pull Request

The amount of query will be 10 less, 65

Link to documentations

Please select:

• Documentation link for docs.joomla.org:
• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org:
• No documentation changes for manual.joomla.org needed

[crommie]

I have tested this item ✅ successfully on 59bd3b7

Before: 61 queries. After: 51 queries.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.}

[chmst]

I have tested this item ✅ successfully on 59bd3b7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.}

[adj9]

I have tested this item ✅ successfully on 59bd3b7

Its ok Queries have decreased

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.}

[chmst]

shuldn't that go into 4.4?

[richard67]

shuldn't that go into 4.4?

Good question. @Fedik Is the unnecessary query an issue in 4.4, too?

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.}

[Fedik]

Is the unnecessary query an issue in 4.4, too?

yeap,

[richard67]

Is the unnecessary query an issue in 4.4, too?

yeap,

@Fedik Then a PR should be made for 4.4-dev.

[Fedik]

I will do another, later

[gilou103]

During PBF
16 Content Article - Custom fields (my Group),
before patch 67 queries, after patch 51 queries

[Fedik]

I moved to 4.4 branch:

• [4.4] Fix of unnecessary SQL query for Fields, get the field value already loaded by getFields() #42882

[richard67]

I've restored the previous human test results as the PR was closed but then reopened, and there was no change since the successful tests.

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.}

[bembelimen]

I moved it to 5.2 as a decision from maintainer

[pe7er]

Thanks @Fedik !