-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Module 'Feed Display': deprecated Notice #42803
Conversation
I have tested this item ✅ successfully on bbe656d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803. |
I came across a problem testing this PR: with an Atom feed there is still a deprecated notice with the patch applied. See this Forum discussion: https://forum.joomla.org/viewtopic.php?f=834&t=1007409&p=3715335#p3715335 and perhaps try this feed url: https://www.youtube.com/feeds/videos.xml?channel_id=UCbayot0NQ0HWeCs9J8Mx7fA I realise fixing an Atom feed may be considered a different issue to fixing an RSS feed. But that would be lost on the end user. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803. |
Oops - I tested with J5 but I think the comment stands. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803. |
I have tested this item ✅ successfully on bbe656d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803. |
@ceford is right |
@ceford should be fixed now the atom feed too |
Thank you! |
Pull Request for Issue #42793 .
Summary of Changes
skip if publishDate is null
Testing Instructions
see #42793
Actual result BEFORE applying this Pull Request
deprecated Notice
Expected result AFTER applying this Pull Request
No deprecated Notice
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed