Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Module 'Feed Display': deprecated Notice #42803

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Feb 13, 2024

Pull Request for Issue #42793 .

Summary of Changes

skip if publishDate is null

Testing Instructions

see #42793

Actual result BEFORE applying this Pull Request

deprecated Notice

Expected result AFTER applying this Pull Request

No deprecated Notice

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon requested a review from chmst as a code owner February 13, 2024 11:37
@Fedik Fedik added the PHP 8.x PHP 8.x deprecated issues label Feb 13, 2024
@ChristineWk
Copy link

I have tested this item ✅ successfully on bbe656d

J 4.4.3-dev


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

@ceford
Copy link
Contributor

ceford commented Feb 20, 2024

I came across a problem testing this PR: with an Atom feed there is still a deprecated notice with the patch applied. See this Forum discussion: https://forum.joomla.org/viewtopic.php?f=834&t=1007409&p=3715335#p3715335 and perhaps try this feed url: https://www.youtube.com/feeds/videos.xml?channel_id=UCbayot0NQ0HWeCs9J8Mx7fA

I realise fixing an Atom feed may be considered a different issue to fixing an RSS feed. But that would be lost on the end user.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

@ceford
Copy link
Contributor

ceford commented Feb 20, 2024

Oops - I tested with J5 but I think the comment stands.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

@fgsw
Copy link

fgsw commented Feb 21, 2024

I have tested this item ✅ successfully on bbe656d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42803.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 21, 2024
@alikon
Copy link
Contributor Author

alikon commented Feb 21, 2024

@ceford is right
just got the same result with https://www.youtube.com/feeds/videos.xml?channel_id=UCbayot0NQ0HWeCs9J8Mx7fA
image

@alikon alikon removed the RTC This Pull Request is Ready To Commit label Feb 21, 2024
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@alikon alikon removed the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@alikon alikon removed the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2024

@ceford should be fixed now the atom feed too

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@MacJoom MacJoom self-assigned this Feb 22, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.4 milestone Feb 22, 2024
@MacJoom MacJoom merged commit 8ea7355 into joomla:4.4-dev Feb 22, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Feb 22, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@alikon alikon deleted the patch-24 branch February 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants