-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Replace deprecated substr() with substring() #42726
Conversation
I have tested this item ✅ successfully on a68b18a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726. |
I have tested this item ✅ successfully on a68b18a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726. |
1 similar comment
I have tested this item ✅ successfully on a68b18a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726. |
I have not tested this item. Using Download / Details at the bottom of the Patch page, Not Found The requested URL was not found on this server. Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42726. |
@exlemor Possibly the downloads are not available anymore because some time after a PR has been updated last time, the downloads are deleted. As the PR already has 2 good tests I have set it to RTC (ready to commit), so it doesn't need any more tests. But I will trigger a new build of the testing packages now by updating the branch so a bit later new downloads will be available. |
Thank you @C-Lodder and also to the testers @ceford @steffans and @viocassel |
Summary of Changes
Javascript's
substr()
method has been deprecated for ages now (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) and this PR replaces it withsubstring()
Testing Instructions
<field name="foo" type="color" label="Test" control="simple" />
) and ensure the field works as expected.I was unable to test the calendar changes as the code has no comments to assist developers, so this might need to be a code review instead.