[4.4] Finder: Fixing language of token #42693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
While debugging another issue, I stumbled upon a problem where the language handed over for a token while indexing is being set to NULL. For this to happen, Finder needs to be set to search for phrases. In that case, the changed line applies the stemming code to each token, but since
$lang
is only a single entry array, that variable is only applied once for the array of tokens. The token array can have between 1 and 3 entries and thus the stemmer for $lang is only applied for the first token and not the rest of the array.Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed