Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Codemirror Full Screen background #42683

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #42647 .

Summary of Changes

Add a background color to the codemirror editor qwhen in full screen

Testing Instructions

In template manager open a file for editing and press f10 to ernter full screen mode

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Jan 21, 2024

I have tested this item ✅ successfully on a70eb35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42683.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jan 21, 2024

I have tested this item ✅ successfully on a70eb35


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42683.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Jan 21, 2024
@alikon
Copy link
Contributor

alikon commented Jan 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42683.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 21, 2024
@alikon alikon added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Jan 21, 2024
@HLeithner HLeithner merged commit 27afb0c into joomla:5.0-dev Jan 21, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 21, 2024
@brianteeman
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants