[4.4] Fixing API authentication issue with Apache with PHP as cgi/fastCGI #42593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine for me :) |
|
@Hackwar Why for 5.0-dev? Either it's a bug fix, then it should go into 4.4-dev, or it's a new feature, then it should go into 5.1-dev. 5.0-dev only makes sense for bug fixes of bugs which affect only 5.x but not 4.4.y. |
Hackwar
force-pushed
the
5.0-api-authentication
branch
from
4cd6328
to
33a2712
Compare
|
I changed it to 4.4-dev |
Hackwar
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
On my local system the token API authentication is not working, since the authorization header is renamed to REDIRECT_HTTP_AUTHORIZATION instead of just HTTP_AUTHORIZATION. Since our API is pretty similar to symfony, I looked at what symfony is doing and Symfony is doing the same like I'm doing here: https://github.com/symfony/symfony/blob/7.0/src/Symfony/Component/HttpFoundation/ServerBag.php#L58
Their original issue is here: symfony/symfony#1813
@SniperSister can you review this/give this a thumbs up?
Testing Instructions
I don't know how Apache needs to be actually configured to trigger this, but I hope this can be accepted by code review?
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed