-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Better message on package uninstallation when an extension is missing #42570
[4.4] Better message on package uninstallation when an extension is missing #42570
Conversation
Better message on package uninstallation when an extension from that package is missing. Fixes issue joomla#42537 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
@chmst Would you say it's a bug fix? Or is it a new feature so it should go into 5.1-dev? I'd like to know your opinion. More opinions are of course welcome. |
Added a link to the Drone packages and custom update URL to the testing instructions. |
In my opinion it is a bug fix. I remember this message in the past. And it could be interesting for users who update from older versions. |
I have tested this item ✅ successfully on cbd9ac1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42570. |
@MacJoom When updating someone’s branch and there is a human test, then please restore the test result in the issue tracker. |
Will merge it anyway after drone build succeeds |
Ah, ok. Thanks. |
Thanks for the PR! |
* Fix link and button colors in header footer (#42504) * [4.x] add php 8.3 to tests (#42545) * Update the signature for #42545 (#42552) * [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550) * Better English (1) * Better English (2) * Remove br html element from language strings * Fixes to form validation process (#42560) Fixes hardening measure introduced in #23716 * [4][com_actionlogs] missed load plugin languages (#42562) * load lang * test-4-dupkey * Better message on package uninstallation (#42570) * Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 . * backport #41865 (#42088) * backport [5] update from nightly to latest nightly build #41865 * [5] harmonize naming task types (#42574) * [5.0] colour contrast in media manager file list [a11y] (#42544) * [5.0] Update phpseclib to 3.0.34 (#42469) * Fix `function` parameter lost during redirect (#42315) * Fix `function` parameter lost during redirect * Move function parameter to form url * Remove hidden input * [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576) * Use concat of columns for getting core extensions * Fix PHPCS * Remove wrong quotes * Revert min version in drone (#42583) * Joomla! 5.0.2 Release Candidate 1 * Revert to dev * [4][com_templates] cast to int for pgsql (#42569) * cast to int for pgsql * yet-another * patch article tags (#42486) * Joomla 5.0.2 Release Candidate 2 * Reset to dev * Update signature HMAC in .drone.yml --------- Co-authored-by: Rick Spaan <rick@r2h.nl> Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: George Wilson <georgejameswilson@googlemail.com> Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com> Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de> Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com> Co-authored-by: David Jardin <d.jardin@djumla.de> Co-authored-by: janschoenherr <jan@yootheme.com>
Pull Request for Issue #42537 .
Summary of Changes
Provide a better warning message on package uninstallation when an extension from that package is missing by mentioning the name of that extension in the message.
A new language string is added for this purpose, which is more or less the same as the first part of the existing
JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER
string and uses the same parameter.The package adapter uses the new string in the same way as the
JLIB_INSTALLER_ERROR_PACK_UNINSTALL_NOT_PROPER
string, i.e. the extensions name is obtained withbasename($extension->filename))
.The old language string
JLIB_INSTALLER_ERROR_PACK_UNINSTALL_UNKNOWN_EXTENSION
is obsolete and therefore deprecated.Testing Instructions
Packages for new installation and updates and a custom update URL created by Drone for this PR can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/4.4-dev/42570/downloads/72522 .
Actual result BEFORE applying this Pull Request
There is a warning message "Trying to uninstall unknown extension from package. This extension may have already been removed earlier.".
Expected result AFTER applying this Pull Request
There is a warning message which contains the name of the extensions, e.g. "Package Uninstall: This extension is missing or has already been uninstalled: mod_helloworld".
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed