Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4][com_actionlogs] missed load plugin languages #42562

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 22, 2023

Pull Request for Issue #28540.

Summary of Changes

load language from:

  • plg_system_privacyconsent
  • plg_user_terms

Testing Instructions

enable user term plugin - register a new user and consent to the terms and conditions during registration.
enable sytem privacy plugin - and consent to the privacy policy.

on dashboard Latest Actions module check that string are translated correctly

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on d1456e9

This works, thanks. A very old mistake.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on d1456e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42562.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 23, 2023
@MacJoom MacJoom self-assigned this Dec 23, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.2 milestone Dec 23, 2023
@MacJoom
Copy link
Contributor

MacJoom commented Dec 23, 2023

@alikon Thanks for the PR - can you think of a reason why drone is failing at administrator/components/com_privacy/Consent.cy.js for psql?

@alikon
Copy link
Contributor Author

alikon commented Dec 24, 2023

somekind of "duplicate key value violates unique constraint cpostgres_users_pkey"

@richard67
Copy link
Member

somekind of "duplicate key value violates unique constraint cpostgres_users_pkey"

Reason could be that some users are inserted into the database with given ID in the insert statement, but on postgresql the sequence value for the ID column is not updated after that.

@MacJoom MacJoom merged commit 3927cea into joomla:4.4-dev Dec 26, 2023
2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 26, 2023
@MacJoom
Copy link
Contributor

MacJoom commented Dec 26, 2023

Thank you!

@alikon alikon deleted the patch-23 branch December 27, 2023 11:47
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants