-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Set permission for add-module-to-dashboard button #42467
[4.4] Set permission for add-module-to-dashboard button #42467
Conversation
Could you explain what the problem is as it is not clear from your post |
resolved now also for this case. |
I have tested this item ✅ successfully on 2eef018 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467. |
In the case of #37267 will still work fine and no need any change after apply this PR |
@chmst delete from summary at least this part: "This PR sets the permission back to core.manage on com_modules." |
I have tested this item 🔴 unsuccessfully on 2eef018 No button for usergroup "Administrator" only for "Super Users". Alternative i have test it with: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467. |
I have tested this item ✅ successfully on 39a1c85
or alternatively change it to: @carlitorweb : Now we need a second test. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467. |
I have tested this item ✅ successfully on 39a1c85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42467. |
Thank you! |
Pull Request for Issue #41624 .
PR #37268 set wrong permission for the "Add module to dahboard" Button on cpanel.
This was caused because a user had a special use case - descibed in #37267
Summary of Changes
This PR sets the permission back to core.manage on com_modules.
Therefore the issue #37267 is unresolved again.
This special use case needs an other solution. Maybe an override of cpanel.
Testing Instructions
You need a user in usergroup manager. Login as manager - you see the button "Add Module to the dashboard".
Activate.
An Error message is displayed.
Apply the patch - no button for usergroup "manager".
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed