[5.0] revert string removal #42388
Merged
[5.0] revert string removal #42388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COM_USERS_MAIL_PLEASE_FILL_IN_THE_FORM_CORRECTLY="Please fill in the form correctly." This string was marked as deprecated in joomla#39374 and removed from 5.0 as a result of the deprecation However this was in error as the string is used https://github.com/joomla/joomla-cms/blob/43a9aab4992d3048e8f2ee5091cd76959fc52acc/administrator/components/com_users/src/Model/MailModel.php#L126 This simple PR restores the string. I have made it against 5.0 as I see this as a bugfix but maintainers may decide its a new string and therefore must be in 5.1
|
I have tested this item ✅ successfully on d3c311e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42388. |
wilsonge
approved these changes
Nov 22, 2023
|
I have tested this item ✅ successfully on d3c311e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42388. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42388. |
|
Thx |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jan 11, 2024
joomla/joomla-cms#42111 + joomla/joomla-cms#42322 + joomla/joomla-cms#42388 + joomla/joomla-cms#42387 + joomla/joomla-cms#42574 - (только для en-GB) + несколько Upmerge с 4.4.2 в 5.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COM_USERS_MAIL_PLEASE_FILL_IN_THE_FORM_CORRECTLY="Please fill in the form correctly."
This string was marked as deprecated in #39374 and removed from 5.0 as a result of the deprecation
However this was in error as the string is used
joomla-cms/administrator/components/com_users/src/Model/MailModel.php
Line 126 in 43a9aab
This simple PR restores the string.
I have made it against 5.0 as I see this as a bugfix but maintainers may decide its a new string and therefore must be in 5.1
Pull Request for Issue # .
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed