Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] TinyMCE add missing event listener #42321

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 8, 2023

Pull Request for Issue #42318 ans #42319 .

Summary of Changes

TinyMCE add missing event listener for AJAX request

Testing Instructions

Edit article, and try use TinyMCE template feature.

Actual result BEFORE applying this Pull Request

Nothing happen.
In browser console an error

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@camminateinfriuli
Copy link

camminateinfriuli commented Nov 8, 2023

I tested #42321 now the button responds but says there are no templates defined
no template

@Fedik
Copy link
Member Author

Fedik commented Nov 8, 2023

Yeah, you have to set up template path in the TinyMCE plugin configuration:
Screenshot 2023-11-08_18-40-05
And place some templates in that path.

I have no idea why it like that now.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5500776


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42321.

@brianteeman
Copy link
Contributor

Works perfectly

image

@Quy
Copy link
Contributor

Quy commented Nov 8, 2023

I have tested this item ✅ successfully on 5500776


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42321.

@Quy
Copy link
Contributor

Quy commented Nov 8, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42321.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 8, 2023
@Quy Quy added this to the Joomla! 5.0.1 milestone Nov 8, 2023
@HLeithner HLeithner merged commit 6eff78c into joomla:5.0-dev Nov 8, 2023
4 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 8, 2023
@Fedik Fedik deleted the fix42318 branch November 8, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants