Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4.0] Fix condition for menuitems #42157

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 18, 2023

Pull Request for Issue # .

Summary of Changes

Fix a condition in saving a menu item.

Testing Instructions

On a fresh 4.4.0 install testing sample data.

Actual result BEFORE applying this Pull Request

grafik

Installation breaks.

Expected result AFTER applying this Pull Request

Installation works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

as this is a backport of #41500 lgtm

@Fedik
Copy link
Member

Fedik commented Oct 18, 2023

I have tested this item ✅ successfully on 5d2a0e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42157.

@Fedik Fedik added the bug label Oct 18, 2023
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 5d2a0e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42157.

@Fedik
Copy link
Member

Fedik commented Oct 18, 2023

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42157.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 18, 2023
@MacJoom MacJoom self-assigned this Oct 30, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.1 milestone Oct 30, 2023
@MacJoom MacJoom enabled auto-merge (squash) October 30, 2023 09:24
@MacJoom MacJoom merged commit 8522720 into joomla:4.4-dev Oct 30, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants