Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Joomla content plugin: Check if param is set before comparing #41500

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Aug 28, 2023

Summary of Changes

When adding a menu item to edit/creates articles, this code checks if the parameter enable_category is equal to 1 and if the catid is set. However, when you add this code not via the menu manager, but manually via some script, it will throw a notice when that parameter is not set. This PR adds a simple check if that param is present before comparing it. Since not setting this equals to 0, this should be fine.

Testing Instructions

Right now, before #41489 is merged, the testing sampledata can not be run, because that parameter is missing. So, install Joomla and run the testing sampledata.

Actual result BEFORE applying this Pull Request

Adding the testing sampledata fails with a notice in the AJAX call.

Expected result AFTER applying this Pull Request

Now it works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Aug 28, 2023

I have tested this item ✅ successfully on 807c364


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41500.

@HLeithner HLeithner enabled auto-merge (squash) August 31, 2023 13:14
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner merged commit ed6ef1f into joomla:5.0-dev Sep 2, 2023
@HLeithner
Copy link
Member

thanks

@Hackwar Hackwar deleted the 5.0-joomla-content branch March 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants