Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Add languages API endpoint #42136

Merged
merged 20 commits into from
Jun 4, 2024
Merged

[5.2] Add languages API endpoint #42136

merged 20 commits into from
Jun 4, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 14, 2023

Summary of Changes

fix for GET {{base_path}}/api/index.php/v1/languages

Testing Instructions

GET {{base_path}}/api/index.php/v1/languages

Actual result BEFORE applying this Pull Request

500 Internal server error

Expected result AFTER applying this Pull Request

200 OK

@toivo
Copy link
Contributor

toivo commented Oct 14, 2023

I have tested this item ✅ successfully on d87a793

Tested successfully in Joomla 4.4.0-rc2-dev of 14 October using PHP 8.2.11 in Wampserver 3.3.1 and Postman Desktop Agent


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42136.

@Quy
Copy link
Contributor

Quy commented Oct 14, 2023

I have tested this item ✅ successfully on d87a793


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42136.

@Quy
Copy link
Contributor

Quy commented Oct 14, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42136.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 14, 2023
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Oct 16, 2023
@laoneo laoneo added Feature and removed bug labels Oct 16, 2023
@laoneo laoneo changed the base branch from 4.4-dev to 5.1-dev October 16, 2023 15:39
@laoneo laoneo self-requested a review as a code owner October 16, 2023 15:39
@laoneo laoneo changed the title [4] webservices GET languages [5.1] webservices GET languages Oct 16, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 16, 2023
@laoneo laoneo changed the title [5.1] webservices GET languages [5.1] Add languages API endpoint Oct 16, 2023
@laoneo
Copy link
Member

laoneo commented Oct 16, 2023

I have rebased this to 5.1 as it is a new feature.

@laoneo
Copy link
Member

laoneo commented Oct 16, 2023

Please wait till 5.1 is fully up to date with 5.0.

@alikon
Copy link
Contributor Author

alikon commented Oct 16, 2023

this pr is not a feature it'a a bug fix
i'm not adding any new endpoint here i'm just fixing response HTTP 500
see https://docs.joomla.org/J4.x:Joomla_Core_APIs

@laoneo
Copy link
Member

laoneo commented Oct 16, 2023

For me it looked like a new feature. Next time it would help when you update the pr description with the link.

@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Oct 21, 2023
@alikon alikon changed the base branch from 5.1-dev to 4.4-dev October 23, 2023 13:22
@nielsnuebel
Copy link
Contributor

I have tested this item ✅ successfully on 7390b4e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42136.

@richard67 richard67 removed the PBF Pizza, Bugs and Fun label Feb 24, 2024
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 24, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42136.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Feb 24, 2024
@richard67 richard67 added this to the Joomla! 5.1.0 milestone Feb 24, 2024
@bembelimen bembelimen removed the Feature label Mar 2, 2024
@alikon
Copy link
Contributor Author

alikon commented Apr 11, 2024

no interest

@alikon alikon closed this Apr 11, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 11, 2024
@alikon alikon reopened this May 19, 2024
@alikon alikon changed the base branch from 5.1-dev to 4.4-dev May 19, 2024 08:29
@alikon alikon changed the base branch from 4.4-dev to 5.1-dev May 19, 2024 08:29
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone May 22, 2024
@Quy Quy added the RTC This Pull Request is Ready To Commit label May 22, 2024
@laoneo laoneo changed the base branch from 5.1-dev to 5.2-dev May 31, 2024 06:39
@laoneo laoneo changed the title [5.1] Add languages API endpoint [5.2] Add languages API endpoint May 31, 2024
@pe7er pe7er merged commit 08fa3b9 into joomla:5.2-dev Jun 4, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 4, 2024
@pe7er
Copy link
Contributor

pe7er commented Jun 4, 2024

Thanks @alikon !

@alikon alikon deleted the getlanguages branch June 4, 2024 10:08
@Quy Quy removed the PR-5.1-dev label Jun 6, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet