-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Fixes the cli installer #42116
Conversation
@dgrammatiko Shouldn't the testing instructions tell to use the public folder option |
Good call, fixed |
|
@richard67 fwiw |
@dgrammatiko
|
Thank for the PR! Confirm is work now! ✅ Hope this includes in 5.0 at next Tuesday. I will use this + Ansible. Make build server easy for me. |
this pr is scheduled for 5.0.1 thanks @rabidgrowth for the test |
Clarification please: I unpacked the J5rc2 package and started from its installation folder. First try I answered all of the questions and entered the root folder:
That ended in an error
I did it again and left the public folder at the default [] and the installation went to completion with no errors. This is before applying the patch.
It has and works fine. So what error should I look for in the installed site? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42116. |
@ceford You put all joomla files inside the folder /Users/ceford/Sites/j5rc2test, yes? Can not use same folder /Users/ceford/Sites/j5rc2test for public. Must use different folder. Example: /Users/ceford/Sites/rabidgrowth. After install ends the site is servered from /Users/ceford/Sites/rabidgrowth. See my issue #42114 . I used folder outside from /var/www for joomla files, then folder inside /var/www for public. Hope this is help for you! |
I see now, the cli installer is used for creating a site within a site or multiple sites on the same server. That did not occur to me. Thanks for the clarification. |
I have tested this item ✅ successfully on ec5c8d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42116. |
@rabidgrowth Could you mark your test result right? It's not enough just to add a comment with a green check mark. It needs to submit your test result in the issue tracker. For doing this, go to https://issues.joomla.org/tracker/joomla-cms/42116 , then use the blue "Test this" at the top left corner, then select your test result and finally submit. Thanks in advance. |
I have tested this item ✅ successfully on ec5c8d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42116. |
Sorry, didn't know. I now marked test inside tracker. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42116. |
@ceford @rabidgrowth Thanks for testing. |
thanks, there is another problem I will create a PR for |
@HLeithner #42120 or another one? |
Nice |
Pull Request for Issue #42114 .
Summary of Changes
Testing Instructions
Install joomla using
cd installation
andphp joomla.php install
.Make sure that you set the public folder option
--public-folder
to a valid directory (or do not provide any options and follow the questions but provide a valid path for the public folder)Actual result BEFORE applying this Pull Request
DB error
Expected result AFTER applying this Pull Request
No errors
Link to documentations
Please select: