Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Add parameter for setting template link color in dark mode #41925

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Sep 25, 2023

Fixes the accessibility of the links when in dark mode.

Summary of Changes

Adds a parameter to control the link color when in dark mode (this is a different color from the current one which doesn't meet a11y requirements).

I'll happily take any advice on how best to word both the label for the field and maybe even adding an option so it's clear. With us already talking "dark hue" and "dark text" it's really not that clear to the user what is going on (in my opinion)

Testing Instructions

Template link now accessible in dark mode to AA and controllable by the user in the template styles.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.0-dev labels Sep 25, 2023
@wilsonge wilsonge marked this pull request as draft September 25, 2023 22:44
@brianteeman
Copy link
Contributor

lgtm

@wilsonge wilsonge changed the title [5.0Add parameter for setting template link color in dark mode [5.0] Add parameter for setting template link color in dark mode Sep 26, 2023
@wilsonge wilsonge marked this pull request as ready for review September 26, 2023 13:49
@wilsonge
Copy link
Contributor Author

OK I'll open it up then. Somehow I'm not sure this will be intuitive like I said. But better to at least allow a11y compliance

@HLeithner HLeithner merged commit c55a187 into joomla:5.0-dev Sep 30, 2023
0 of 2 checks passed
@HLeithner
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants