Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Template-param-brand #41458

Merged
merged 4 commits into from
May 11, 2024
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Aug 26, 2023

Pull Request for Issue #37352 .

Summary of Changes

Change the filter for brand to "options".

Testing Instructions

see #37352.

Actual result BEFORE applying this Pull Request

{"brand":"true", in database after updating a template copy

Expected result AFTER applying this Pull Request

{"brand":"1"," after updating a template copy

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst chmst added PBF Pizza, Bugs and Fun Small A PR which only has a small change labels Aug 26, 2023
@richard67 richard67 added the bug label Aug 26, 2023
@ceford
Copy link
Contributor

ceford commented Sep 12, 2023

I have tested this item ✅ successfully on 8f84067


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.

@HLeithner HLeithner added the RMDQ ReleaseManagerDecisionQueue label Oct 5, 2023
@HLeithner HLeithner changed the title Template-param-brand [5.0] Template-param-brand Oct 5, 2023
@HLeithner
Copy link
Member

I would like to clarify first what is "true" and what is "false", in joomla we have a bunch of diffrent implementation what means "false" as string false as boolean and "0" as string and int and yes or no at least it's not always handled the same.

In this case saving a bool as 0 and 1 seems to be the right thing, problem could be using it in a different like
in this example https://3v4l.org/PSoL5

So we should check the complete codebase for inconsistency and find a solution normalize this. Pretty sure someone did this already and the PR has not been merged or has been closed or is still open don't know.

I bring this topic up in the next maintainer meeting.

For now I target this pr for 5.0.1

@HLeithner HLeithner added this to the Joomla! 5.0.1 milestone Oct 7, 2023
@Fedik

This comment was marked as outdated.

@dautrich
Copy link

I have tested this item ✅ successfully on 8f84067


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.

@richard67 richard67 removed PBF Pizza, Bugs and Fun bug RMDQ ReleaseManagerDecisionQueue PR-5.0-dev Small A PR which only has a small change labels Nov 18, 2023
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.0.1 milestone Nov 18, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 18, 2023
@richard67 richard67 added bug RMDQ ReleaseManagerDecisionQueue PR-5.0-dev Small A PR which only has a small change labels Nov 18, 2023
@bembelimen bembelimen changed the base branch from 5.0-dev to 5.1-dev March 13, 2024 23:30
@HLeithner HLeithner changed the title [5.0] Template-param-brand [5.1] Template-param-brand Apr 24, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.1 milestone May 11, 2024
@bembelimen bembelimen merged commit 8038f08 into joomla:5.1-dev May 11, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.1-dev RMDQ ReleaseManagerDecisionQueue Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants