Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] schemaorg remove double space #41401

Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Aug 20, 2023

Summary of Changes

unnecessary space removed

Testing Instructions

check links works for all schemes or code review
image

Actual result BEFORE applying this Pull Request

link works

Expected result AFTER applying this Pull Request

link works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.0-dev labels Aug 20, 2023
@Quy
Copy link
Contributor

Quy commented Aug 20, 2023

I have tested this item ✅ successfully on 53991c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41401.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 53991c4

Code review. Redundant spaces removed, necessary spaces still there.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41401.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41401.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2023
@HLeithner HLeithner merged commit 4a33dd6 into joomla:5.0-dev Aug 20, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 20, 2023
@heelc29 heelc29 deleted the 5.0/schemaorg/lang-files/double-space branch August 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants