Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upmerge 20230721 from 4.3-dev #41200

Merged
merged 26 commits into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
01deee0
Joomla! 3.10.11 Stable
zero-24 Aug 14, 2022
4d5e843
reset to dev
zero-24 Aug 14, 2022
170805f
Translation Update (#40731)
joomla-translation-bot Jun 30, 2023
f900ab8
[4.3] Update readme (#41088)
heelc29 Jul 1, 2023
3a44db8
Color issue (#40435)
sandewt Jul 2, 2023
d358b5a
Update CA cert file (#39116)
github-actions[bot] Jul 2, 2023
f58c2dd
Joomla! 3.10.12 Release Candidate 1
zero-24 Jul 2, 2023
3d8e6d2
reset to dev
zero-24 Jul 2, 2023
6bac8a9
Joomla! 4.3.3 RC 1
obuisard Jul 2, 2023
3b63e13
Revert to dev
obuisard Jul 2, 2023
d05b8fd
Merge branch '3.10-dev' of upstream into 4.3-dev
obuisard Jul 3, 2023
f9aa173
Revert to dev
obuisard Jul 6, 2023
b0baf82
Joomla! 3.10.12 Stable
zero-24 Jul 8, 2023
a4ba1df
reset to dev
zero-24 Jul 8, 2023
c944137
Translation Update (#41100)
joomla-translation-bot Jul 9, 2023
23cf1ae
Joomla! 4.3.3 Stable
obuisard Jul 6, 2023
07a1dbd
Merge branch '3.10-dev' of upstream into 4.3-dev
obuisard Jul 11, 2023
d92cdc3
[4.3] typo (#41121)
brianteeman Jul 14, 2023
5be7121
fix on change JavaScript event on color form field with layout advanc…
jurihahn Jul 14, 2023
e367bf8
[4.3] check of invalid json 'joomla.asset.json' (#41135)
heelc29 Jul 14, 2023
955e4d6
[4.3] Colour fields doc blocks (#41128)
brianteeman Jul 14, 2023
c0b1cbc
[4.3] guided tours module count (#40447)
brianteeman Jul 14, 2023
87012fa
[4.3] Single line comment (#41168)
brianteeman Jul 15, 2023
eb23b9b
[4.3] Fix workflow filter (#41167)
brianteeman Jul 18, 2023
63e43cf
Record currentStepId in sessionStorage when responding to an interact…
GeraintEdwards Jul 18, 2023
05e40fc
Merge branch '4.3-dev' into Upmerge-20230721
MacJoom Jul 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ If it is a PR, include what the issue is, what the PR is addressing, testing ins
Please be patient as not all items will be tested immediately (remember, all bug testing for the Joomla! CMS is done by volunteers) and be receptive to feedback about your code.

#### Branches
PRs should usually be made to the `4.2-dev` branch as this contains the most recent version of the code.
PRs should usually be made to the `4.3-dev` branch as this contains the most recent version of the code.
There are other branches available which serve specific purposes.

| Branch | Purpose |
| ------ | ------- |
| 3.10-dev | Branch for the Joomla 3.x series. The 3.10 series release will now only include security patches. |
| 4.2-dev | Branch for the current minor Joomla version.|
| 4.3-dev | Branch for the next minor Joomla version. New features go into this branch. Commits to 4.2-dev will be applied to this branch as well. |
| 5.0-dev | Branch for the next major Joomla version. |
| 4.3-dev | Branch for the current minor Joomla version.|
| 4.4-dev | Branch for the next minor Joomla version. Commits to 4.3-dev will be applied to this branch as well. |
| 5.0-dev | Branch for the next major Joomla version. New features go into this branch. |
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
label="JOPTION_SELECT_STAGE"
class="js-select-submit-on-change"
activeonly="true"
extension="com_content"
extension="com_content.article"
>
<option value="">JOPTION_SELECT_STAGE</option>
</field>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
<?php // load the pagination. ?>
<?php echo $this->pagination->getListFooter(); ?>

<?php //Load the batch processing form. ?>
<?php // Load the batch processing form. ?>
<?php
if (
$user->authorise('core.create', $component)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
<?php // load the pagination. ?>
<?php echo $this->pagination->getListFooter(); ?>

<?php //Load the batch processing form. ?>
<?php // Load the batch processing form. ?>
<?php
if (
$user->authorise('core.create', $component)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ public function save($data)
$data['source'] = str_replace(["\r\n", "\r"], "\n", $data['source']);

// If the asset file for the template ensure we have valid template so we don't instantly destroy it
if ($fileName === '/joomla.asset.json' && json_decode($data['source']) === null) {
if (str_ends_with($fileName, '/joomla.asset.json') && json_decode($data['source']) === null) {
$this->setError(Text::_('COM_TEMPLATES_ERROR_ASSET_FILE_INVALID_JSON'));

return false;
Expand Down
19 changes: 8 additions & 11 deletions administrator/modules/mod_guidedtours/tmpl/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@
->getWebAssetManager()
->useScript('bootstrap.dropdown');

$lang = $app->getLanguage();

$extension = $app->getInput()->get('option');

$listTours = [];
$allTours = [];
$lang = $app->getLanguage();
$extension = $app->getInput()->get('option');
$listTours = [];
$allTours = [];
$toursCount = $params->get('tourscount', 7);

foreach ($tours as $tour) :
if (count(array_intersect(['*', $extension], $tour->extensions))) :
if ($toursCount > 0 && count(array_intersect(['*', $extension], $tour->extensions))) :
$listTours[] = $tour;
$toursCount--;
endif;

$uri = new Uri($tour->url);
Expand Down Expand Up @@ -64,10 +64,7 @@
<span class="icon-angle-down" aria-hidden="true"></span>
</button>
<div class="dropdown-menu dropdown-menu-end">
<?php foreach ($listTours as $i => $tour) : ?>
<?php if ($i >= $params->get('tourscount', 7)) : ?>
<?php break; ?>
<?php endif; ?>
<?php foreach ($listTours as $tour) : ?>
<button type="button" class="button-start-guidedtour dropdown-item" data-id="<?php echo $tour->id ?>">
<span class="icon-map-signs" aria-hidden="true"></span>
<?php echo $tour->title; ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,11 @@ function startTour(obj) {
break;

case 'button':
tour.next();
ele.addEventListener('click', () => {
// the button may submit a form so record the currentStepId in the session storage
sessionStorage.setItem('currentStepId', obj.steps[index].id + 1);
tour.next();
});
break;

case 'other':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ a {
text-decoration: underline;
}

&:hover,
&:focus {
&:not(.btn):hover,
&:not(.btn):focus {
color: var(--cassiopeia-color-hover);
}

Expand Down
2 changes: 1 addition & 1 deletion installation/language/af-ZA/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Afrikaans (Suid-Afrika)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Afrikaans Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/ar-AA/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Arabic (اللغة العربية)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Dr. Ashraf Damra</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
1 change: 1 addition & 0 deletions installation/language/bg-BG/joomla.ini
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ INSTL_DATABASE_NAME_MSG_POSTGRES="Некоректно име на базата
INSTL_DATABASE_NO_SCHEMA="Не съществува схема за избрания вид база данни."
INSTL_DATABASE_PASSWORD_DESC="Въведете парола която сте създали или е предоставена от хостинга Ви."
INSTL_DATABASE_PREFIX_DESC="Въведете префикс на таблица или използвайте произволно генерирания."
INSTL_DATABASE_PREFIX_DUPLICATE_DESC="Ако използвате съществуваща база данни с таблици със същия префикс, Joomla ще преименува тези съществуващи таблици, като добави префикса \"bak_\"."
INSTL_DATABASE_PREFIX_MSG="Префиксът на таблицата трябва да започва с буква и по избор да бъде последван от буквено -цифрови знаци и долна черта"
INSTL_DATABASE_RESPONSE_ERROR="Инсталирането е неуспешно."
INSTL_DATABASE_TYPE_DESC="Изберете тип база данни."
Expand Down
2 changes: 1 addition & 1 deletion installation/language/bg-BG/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Bulgarian (bg-BG)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Bulgaria</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/ca-ES/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Catalan (ca-ES)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Catalan Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/cs-CZ/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Czech (Čeština)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Czech Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/cy-GB/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Welsh (United Kingdom)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project - Welsh Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/da-DK/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Danish (Danmark)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Danish Translation Team (Transl.: Ronny Buelund)</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/de-LI/joomla.ini
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ INSTL_DEFAULTLANGUAGE_FRONTEND_SET_DEFAULT="Die Sprache mit dem Sprach-Tag „%s
INSTL_DEFAULTLANGUAGE_SET_DEFAULT_LANGUAGE="Standardsprache konfigurieren"
INSTL_DEFAULTLANGUAGE_TRY_LATER="Weitere Sprachen können auch noch später in der Administration von Joomla! installiert werden."

INSTL_DEFAULTLANGUAGE_NATIVE_LANGUAGE_NAME="Deutsch (Lichtenstein)" ; IMPORTANT NOTE FOR TRANSLATORS: Do not literally translate this line, instead add the localised name of the language. For example Spanish will be Español
INSTL_DEFAULTLANGUAGE_NATIVE_LANGUAGE_NAME="Deutsch (Liechtenstein)" ; IMPORTANT NOTE FOR TRANSLATORS: Do not literally translate this line, instead add the localised name of the language. For example Spanish will be Español

; Database Model
INSTL_DATABASE_COULD_NOT_CONNECT="Es konnte keine Verbindung zur Datenbank hergestellt werden. Der Konnektor gab folgenden Fehler zurück: %s."
Expand Down
6 changes: 3 additions & 3 deletions installation/language/de-LI/langmetadata.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<metafile client="installation">
<name>German (Lichtenstein)</name>
<name>German (Liechtenstein)</name>
<version>4.3.2</version>
<creationDate>2023-05</creationDate>
<author>J!German</author>
Expand All @@ -11,8 +11,8 @@
<filename>joomla.ini</filename>
</files>
<metadata>
<name>German (Lichtenstein)</name>
<nativeName>Deutsch (Lichtenstein)</nativeName>
<name>German (Liechtenstein)</name>
<nativeName>Deutsch (Liechtenstein)</nativeName>
<tag>de-LI</tag>
<rtl>0</rtl>
</metadata>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/el-GR/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Greek (el-GR)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Ομάδα Μετάφρασης: joomla. gr</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-AU/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>English (Australia)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-CA/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>English (Canada)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-NZ/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>English (New Zealand)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/en-US/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>English (United States)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/es-ES/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Spanish (Spain)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Spanish [es-ES] Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/et-EE/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Estonian</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/eu-ES/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Basque</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Basque Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/fa-AF/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>فارسی (دری)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>JoomlaPersian Translation Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/fa-IR/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Persian (پارسی)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>JoomlaFarsi.Com Team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/fi-FI/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Finnish (Suomi)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Finnish translation team: Joomla.fi</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/fr-FR/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>French (fr-FR)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project - French translation team</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
2 changes: 1 addition & 1 deletion installation/language/he-IL/langmetadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<metafile client="installation">
<name>Hebrew (Israel)</name>
<version>4.3.3</version>
<creationDate>2023-05</creationDate>
<creationDate>2023-07</creationDate>
<author>Joomla! Project</author>
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
Expand Down
Loading