End of Support Plugin for Joomla 4.4

[mfleeson]

Pull Request for Issue # .

Originally this code was monitored and checked in #40556
I messed up my local installation and then managed to close the original PR when I renamed the branch. Mea Culpa. My apologies.

Summary of Changes

Rewriting the 3.10 End of Service Notification and placing it into Joomla 4 coding structure and style.
Simplified the language definitions to not be hardcoded for 3 to 4
Currently using const EOS_DATE = '2023-10-25'; in file plugins/quickicon/eos/src/Extension/Eos.php The correct date should be 2025-10-25 but then the notification does not appear.
Dimitris converted the jQuery code into working javascript for closing the notification and also calling the com_ajax so the hide me is stored in the plugin parameters.

Testing Instructions

Build.
Check plg_quickicon_eos is enabled.
View Home Dashboard in the back end.

Actual result BEFORE applying this Pull Request

No notification is displayed

Expected result AFTER applying this Pull Request

A notification is displayed

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[alikon]

I messed up my local installation

@mfleeson: me ? quite often too 😃

[mfleeson]

Build is failing due to a missing , in the base.sql file and when that's manually corrected the announcement is displayed and closes. But does not appear to call the ajax to write back to the database. Need to investigate further now I have a working 4.4 site.

[laoneo]

Please do not catch all the exceptions better to propagate them to the client.

[mfleeson]

I've come to the code this morning knowng that a lot of the changes being requested have been made and git tells me my fork which is based 4.4 is behind. It offered sync the fork which i clicked and it synced it with 4.3! so now it's saying i'm 140 commits ahead of 4.3. I don't understand how even though I created the fork on 4.4 and it worked fine yesterday it's now all gone back to 4.3. And I'm not sure how to get my fork back to 4.4 so I can make these last few uploads. Hope someone can help.

[mfleeson]

Overnight this PR has aquired extra files which are not part of my commit. When I try and remove them from the PR I get Looks like something went wrong!

We track these errors automatically, but if the problem persists feel free to contact us. In the meantime, try refreshing.

[mfleeson]

It just gets better, I have the definitive code but it wont let me push it and gives the error "remote: fatal: bad tree object fa00be88a9b5283659b312b36877286b9c8f1f08 remote: aborting due to possible repository corruption on the remote side.
fatal: protocol error: bad pack header"

[mfleeson]

Here's the final code - https://drive.google.com/file/d/1pOdbTct0oFA82X0A2sIHTfgWIeRHTRaY/view?usp=share_link

[laoneo]

I think it should be back to normal, merged 4.3 into 4.4 and updated this pr.

[dgrammatiko]

@mfleeson to fix the failing tests change this line

joomla-cms/build/media_source/plg_system_stats/js/stats-message.es6.js

Line 75 in 5770ed6

messageContainer.insertAdjacentHTML('beforeend', Joomla.sanitizeHtml(json.html, allowed));

to

messageContainer.insertAdjacentHTML('afterbegin', Joomla.sanitizeHtml(json.html, allowed));

[laoneo]

Thank you very much to all the testers and reviewers here, and especially @mfleeson for your great work. Just a short reminder. We will ship the first alpha on 30 May. So it would be cool to heave it ready in a proper state by the end of this week. Then we have enough time to iron out some bugs till the shipping date.

[richard67]

Thank you very much to all the testers and reviewers here, and especially @mfleeson for your great work. Just a short reminder. We will ship the first alpha on 30 May. So it would be cool to heave it ready in a proper state by the end of this week. Then we have enough time to iron out some bugs till the shipping date.

@laoneo @mfleeson It still needs to change the EOS date to the right value here: https://github.com/joomla/joomla-cms/pull/40565/files#diff-43fd4a40d7409ad1e608154c3e900ae13a92340cf68d97225fccdcc9e300c008R42 . We can't leave it like it is because the value '2023-10-25' was just for testing purpose.

[dgrammatiko]

On top of what @richard67 wrote above there's #40599 which fixes the tests (the last 2-3 commits). I guess @laoneo should decide if he wants the tests fixed with this PR or in another.

[laoneo]

All I wanted to point out was that the failing tests should not hold back the progress of this pr. If they can get fixed it is even better.

[sandewt]

When you click on the image with the text, a link will open in the same screen. It would be nicer to open the documentation in another screen (target="_blank"), like in the J3 plugin.
I don't see immediately a solution when I look at the code. Because J4 is something different.

An adjustment is not in a hurry at the moment. Can always do so later if we think this should be done.

[richard67]

@sandewt Yes, I've noticed that, too. It might be out of the scope of this PR here to fix that because it seems to be a general thing with the quickicons in J4.

[dgrammatiko]

FWIW #40602 should fix the failing tests so only the date should be changed here. @laoneo check the #40602

[MacJoom]

@mfleeson Thank you for your work - could you please change the date to correct value in 2025?

[sandewt]

Update Eos.php - set hardcoded date to 2025-10-25

Something is wrong here, the date is not correct according to the roadmap.

[mfleeson]

The reason I hadn't set the final date was because it was being discussed at a recent meeting. Also the text definitions still need to be updated once finalised. Please reopen my branch. The current date from https://developer.joomla.org/roadmap.html is 17th October 2025 for end of support for J4.X

[heelc29]

@MacJoom Could you please add the milestone for J4.4?