Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours fix js error #40282

Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 1, 2023

Summary of Changes

fix call of Joomla.renderMessages

Testing Instructions

set an invalid data-id for example data-id="0"

<button type="button" class="button-start-guidedtour dropdown-item" data-id="<?php echo $tour->id ?>">

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

error message is rendered without js error
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Apr 1, 2023
@Quy
Copy link
Contributor

Quy commented Apr 1, 2023

I have tested this item ✅ successfully on 9d852f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 9d852f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Apr 2, 2023
@obuisard obuisard merged commit 04b9ee8 into joomla:4.3-dev Apr 2, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2023
@obuisard
Copy link
Contributor

obuisard commented Apr 2, 2023

Thank you @heelc29 for the PR

@heelc29 heelc29 deleted the 4.3/plg_system_guidedtours/js-error branch April 2, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants