Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Help button link urls #40270

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[4.3] Help button link urls #40270

merged 1 commit into from
Mar 31, 2023

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #40268 .

Summary of Changes

  • The URL for the help pages has escaped forward slashes

Testing Instructions

Navigate anywhere in the backend where the toolbar has a help button and click on it

Actual result BEFORE applying this Pull Request

Broken

Expected result AFTER applying this Pull Request

The help popup should return a 404 page (this is a different problem)

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@obuisard I guess this is a release blocker

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 3bd1730


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Mar 31, 2023

I have tested this item ✅ successfully on 3bd1730


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270.

@joomla-cms-bot joomla-cms-bot changed the title [4.3] Help button link urls [4.3] Help button link urls Mar 31, 2023
@alikon
Copy link
Contributor

alikon commented Mar 31, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270.

@joomla-cms-bot joomla-cms-bot added PR-4.3-dev RTC This Pull Request is Ready To Commit labels Mar 31, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 31, 2023
@obuisard obuisard merged commit 3ff8356 into joomla:4.3-dev Mar 31, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2023
@obuisard
Copy link
Contributor

Thank you Dimitris @dgrammatiko. Yes, this needed to be in. Thank you very much for the PR.

@dgrammatiko dgrammatiko deleted the patch-5 branch March 31, 2023 17:21
Denitz pushed a commit to Denitz/joomla-cms that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants