-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] [Guided Tours] Fancy select fields are broken and not accessible in tours #40238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.3-dev
labels
Mar 30, 2023
I have tested this item ✅ successfully on b207e33 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238. |
Quy
reviewed
Mar 31, 2023
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-03-29.sql
Show resolved
Hide resolved
Update step of id 5
Update step of id 5
Update step of id 5
Update step of id 5
Khushi @khu5h1, do you mind testing again? Specifically the component field for the guided tours tour on new install. |
I have tested this item ✅ successfully on d8d7b7f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238. |
1 similar comment
I have tested this item ✅ successfully on d8d7b7f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40211 .
Summary of Changes
Categories and tags are fancy select fields. Although tags can be selected in tours, categories can not.
This PR fixes categories and improves the tags selection fields.
Fields can be tabbed through, categories and tags selected (to select a category or tab, use the arrow keys) or added, as intended.
Testing Instructions
Take the article tour up to the category field.
Tab through to see that the popup and the field keep focus and you can go from one to the other.
Once it has focus, the field's dropdown should open (if you tab through or click on the field).
A category can be entered. To access already existing categories, use the arrow keys.
Press enter on the category and the article will change to the new category.
You will loose the 'back' button in the popup, since a refresh has been made.
Go down and test the tags the same way. This time there is no refresh when selecting tags.
Take the tour for guided tours. Check the component parameter as well.
Actual result BEFORE applying this Pull Request
You cannot select or add a category.
Expected result AFTER applying this Pull Request
You can select or add a category.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed