Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] [Guided Tours] Fancy select fields are broken and not accessible in tours #40238

Merged
merged 9 commits into from
Mar 31, 2023

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Mar 30, 2023

Pull Request for Issue #40211 .

Summary of Changes

Categories and tags are fancy select fields. Although tags can be selected in tours, categories can not.
This PR fixes categories and improves the tags selection fields.
Fields can be tabbed through, categories and tags selected (to select a category or tab, use the arrow keys) or added, as intended.

Testing Instructions

Take the article tour up to the category field.
Tab through to see that the popup and the field keep focus and you can go from one to the other.
Once it has focus, the field's dropdown should open (if you tab through or click on the field).
A category can be entered. To access already existing categories, use the arrow keys.
Press enter on the category and the article will change to the new category.
You will loose the 'back' button in the popup, since a refresh has been made.

Go down and test the tags the same way. This time there is no refresh when selecting tags.

Take the tour for guided tours. Check the component parameter as well.

Actual result BEFORE applying this Pull Request

You cannot select or add a category.

Expected result AFTER applying this Pull Request

You can select or add a category.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@khu5h1
Copy link
Contributor

khu5h1 commented Mar 30, 2023

I have tested this item ✅ successfully on b207e33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

Update step of id 5
Update step of id 5
Update step of id 5
Update step of id 5
@obuisard
Copy link
Contributor Author

Khushi @khu5h1, do you mind testing again? Specifically the component field for the guided tours tour on new install.
Thanks in advance, I apologize for the mistake.

@khu5h1
Copy link
Contributor

khu5h1 commented Mar 31, 2023

I have tested this item ✅ successfully on d8d7b7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 31, 2023

I have tested this item ✅ successfully on d8d7b7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

@Quy
Copy link
Contributor

Quy commented Mar 31, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2023
@sdwjoomla sdwjoomla added this to the Joomla! 4.3.0 milestone Mar 31, 2023
@sdwjoomla sdwjoomla merged commit 7594a02 into joomla:4.3-dev Mar 31, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 31, 2023
Denitz pushed a commit to Denitz/joomla-cms that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants