-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Tinymce - style previews #40206
Conversation
@brianteeman I tested and also tried an alternative option. I added the image background style to the array. |
thats not a good approach. As tinymce provide an option xpecifically for this then we should use it. |
This is probably due to the fact that it was decided not to use the |
Are there any plans to go back to the idea of using the |
it is irrelevant. it is not the correct way to do this. when there is a documented api it should always be used. Especially when it is from a third party. Then you will know that if they change it you will need to update. |
I meant in major versions a return to using the BASE tag, with new rules with new functions, with a new API |
this is not the topic of this Pull Request. Every time you go off topic you delay the changes. I made this pull request because you asked for it. if you dont want it then I will simply close it and do something more interesting. |
Thanks. I tested it. Excellent. Everything works. I didn't want to delay. I am very grateful. I was interested about a general question. |
I have tested this item ✅ successfully on daf8b27 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40206. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40206. |
Thanks Brian @brianteeman, great PR. |
thx |
Thanks Brian Teeman |
Pull Request for Issue #40079 .
Summary of Changes
Specify the atributes to be used when previewing a style. This prevents white text on a white background making the preview invisible.
Testing Instructions
Add the following class to
media\system\css\editor.css
ormedia\system\css\editor.min.css
(depends if you have debug onActual result BEFORE applying this Pull Request
You cannot see the class in the menu as its color of white is used in the preview and makes it invisible
Expected result AFTER applying this Pull Request
You can see the class as we don't preview colours in the menu
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed