[4.4] Cypress test for popular articles in mod_articles_popular

[sandewt]

Pull Request for Issue # .

Add mod_articles_popular system test.

[sandewt]

Result of the (local) Cypress test in browser

[brianteeman]

Surely thats just testing if the module loads something and not that it loads something popular

[sandewt]

Surely thats just testing if the module loads something and not that it loads something popular

It would indeed be nicer to load, for example, the last five articles with one of them with the title of the test article.
The question is whether that is possible in a simple way.

I've tried that but haven't gotten it done yet.

[laoneo]

For now this is ok, we can always add more tests in the future when we get more experience.

[sandewt]

This can be achieved very easily, without the automated test article

[sandewt]

@laoneo very easy to change

.then(() => cy.db_createModule({ module: 'mod_articles_popular', params: JSON.stringify({ catid: 2 }) }))
becomes
.then(() => cy.db_createModule({ module: 'mod_articles_popular }))

[EDIT I can make a new pr]

[sandewt]

Note; It would then be nice to use an if statement if there are no articles yet

[laoneo]

Tests should not have conditions and you have to always assume the database is empty. So you have to setup tthe database in a way you want to test it.

[sandewt]

Thanks