Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless strpos() checking #40133

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Mar 16, 2023

Summary of Changes

The patch removes useless strpos() check.
This event is set up in AssetRegistry by class name already. Also it is not a system wide event, and never should be.

Testing Instructions

Apply patch, and check that the site works as before.

Actual result BEFORE applying this Pull Request

Works.

Expected result AFTER applying this Pull Request

Works.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomdonation
Copy link
Contributor

Tested and nothing is broken. But please remove the unused use statement

use Joomla\CMS\Event\WebAsset\WebAssetRegistryAssetChanged;

@Fedik
Copy link
Member Author

Fedik commented Mar 16, 2023

done

@toivo
Copy link
Contributor

toivo commented Mar 16, 2023

I have tested this item ✅ successfully on 048a4e9

Tested successfully in Joomla 4.3.0-beta5-dev of 16 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 048a4e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 17, 2023
@Hackwar Hackwar added the bug label Apr 8, 2023
@obuisard obuisard merged commit 955936c into joomla:4.3-dev May 4, 2023
@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 4, 2023
@obuisard
Copy link
Contributor

obuisard commented May 4, 2023

Thanks Fedir @Fedik !

@Fedik Fedik deleted the rm-strpos-ev branch May 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants