Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Use HelperFactory to get Helper for mod_quickicon #40018

Merged

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR makes small changes to mod_quickicon code to use HelperFactory to get it's Helper class. It has two benefits:

  1. Consistent code with how we are getting Helper for other modules. For example https://github.com/joomla/joomla-cms/blob/4.2-dev/modules/mod_articles_latest/src/Dispatcher/Dispatcher.php#L41
  2. Save the system from having to go to bootModule routine again before it can get module helper class.

Testing Instructions

  1. Use Joomla 4.3 nightly build
  2. Apply patch
  3. Access to administrator area of your site, look at Home Dashboard, Notifications section. Make sure the icons there are still being displayed (see the attached screenshot)

quick_icons

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 632ec44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

1 similar comment
@chmst
Copy link
Contributor

chmst commented Mar 12, 2023

I have tested this item ✅ successfully on 632ec44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

@chmst chmst removed the PR-4.3-dev label Mar 12, 2023
@chmst
Copy link
Contributor

chmst commented Mar 12, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2023
@chmst chmst added this to the Joomla! 4.3.0 milestone Mar 12, 2023
@Quy Quy added the PR-4.3-dev label Mar 12, 2023
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 4.3.0 milestone Mar 12, 2023
@Hackwar Hackwar added bug Feature and removed bug labels Apr 8, 2023
@laoneo laoneo changed the base branch from 4.3-dev to 4.4-dev May 2, 2023 16:36
@laoneo laoneo changed the title [4.3] Use HelperFactory to get Helper for mod_quickicon [4.4] Use HelperFactory to get Helper for mod_quickicon May 2, 2023
@laoneo laoneo self-assigned this May 2, 2023
@laoneo laoneo merged commit f99abb1 into joomla:4.4-dev May 5, 2023
@laoneo
Copy link
Member

laoneo commented May 5, 2023

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone May 5, 2023
@joomdonation joomdonation deleted the use_helper_factory_for_mod_quick_icon branch February 24, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants