-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Finder ajax error handling #39973
Conversation
I am confused .. @Fedik this is for 4.2 while @Hackwar has a PR for 4.3. I have tested this PR on a 4.2 multilingual with blog sample data. But the output freezes without error message. Repeated the test with the prebuild package and got a message |
I have tested this item ✅ successfully on 5d37ee4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973. |
1 similar comment
I have tested this item ✅ successfully on 5d37ee4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973. |
Thank you |
Pull Request for Issue #39717 and #39965 .
Summary of Changes
Catch broken json and show an error message.
For Finder indexer, and for Finder autocomplete.
Testing Instructions
Apply patch, run
npm install
.Repeat test from [5.0] Smart Search: Improving error handling of Indexing #39965
Go to a finder plugin, for example
/plugins/finder/content/src/Extension/Content.php
and trigger any output in theindex()
method. For example you can addvar_dump($item->title)
.In the Smart Search component in the backend click on "Index".
And similar for Autocomplete.
Add
var_dump(['error'])
somewhere herejoomla-cms/components/com_finder/src/Controller/SuggestionsController.php
Lines 34 to 38 in 10f250f
Make sure autocomplete is enabled, then go to site search page, and try to search something.
Actual result BEFORE applying this Pull Request
The ajax stops without any visible signs of life.
Expected result AFTER applying this Pull Request
You should get an error message.
Link to documentations
Please select: