Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Media Manager Ordering #39732

Merged
merged 19 commits into from
Jan 30, 2023
Merged

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Jan 27, 2023

Pull Request for Issue # .

Summary of Changes

  • Base work for the ordering
  • Supports: name, size, dimensions, date created and date modified

The TODO here is to expose to the icons view the ui (ie dropdown, series of buttons, etc) to control the ordering. Right now you have to switch to the table view to select another column for ordering...

Testing Instructions

Apply the PR and run npm ci

Check the grid layout of the media browser and click on the table headers

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screenshot 2023-01-29 at 13 29 48
Screenshot 2023-01-29 at 13 30 11

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jan 27, 2023
@dgrammatiko dgrammatiko changed the title [4.3] Media Manager sorting [4.3] Media Manager Ordering Jan 27, 2023
Refactor the import of the components
@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

The Upload button is no longer working. Clicking it does nothing.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Jan 29, 2023
@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

Maybe change it to caret to match elsewhere. Also, the arrow is opposite direction compared to elsewhere.

39732

@dgrammatiko
Copy link
Contributor Author

Maybe change it to caret to match elsewhere. Also, the arrow is opposite direction compared to elsewhere.

@Quy should be ok now

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

To be consistent elsewhere, the caret direction should reflect the current ordering.

@dgrammatiko
Copy link
Contributor Author

To be consistent elsewhere, the caret direction should reflect the current ordering.

done

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

Sorry one minor change so the last word is not cut off. Make both dropdowns col-3.

39732-dropdown

dgrammatiko and others added 2 commits January 29, 2023 20:03
@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

I have tested this item ✅ successfully on 3becfe4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

Fix gap.

39741-gap

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

I have tested this item ✅ successfully on 366d186

THANK YOU!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 366d186

👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 29, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 30, 2023
@obuisard obuisard merged commit 5d14d67 into joomla:4.3-dev Jan 30, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 30, 2023
@obuisard
Copy link
Contributor

Great PR. Thank you Dimitris @dgrammatiko.

@dgrammatiko dgrammatiko deleted the 4.3-dev-mm-ordering branch January 30, 2023 07:25
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants