-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Media Manager Ordering #39732
[4.3] Media Manager Ordering #39732
Conversation
The Upload button is no longer working. Clicking it does nothing. |
@Quy should be ok now |
To be consistent elsewhere, the caret direction should reflect the current ordering. |
done |
administrator/components/com_media/resources/scripts/store/mutation-types.es6.js
Outdated
Show resolved
Hide resolved
…ation-types.es6.js Co-authored-by: Quy <quy@nomonkeybiz.com>
administrator/components/com_media/tmpl/media/default_texts.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on 3becfe4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732. |
I have tested this item ✅ successfully on 366d186 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732. |
I have tested this item ✅ successfully on 366d186 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732. |
Great PR. Thank you Dimitris @dgrammatiko. |
Pull Request for Issue # .
Summary of Changes
The TODO here is to expose to the icons view the ui (ie dropdown, series of buttons, etc) to control the ordering. Right now you have to switch to the table view to select another column for ordering...Testing Instructions
Apply the PR and run
npm ci
Check the grid layout of the media browser and click on the table headers
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed