Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha3 #39685

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jan 21, 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 4.3-dev branch in preparation for the upcoming 4.3.0-alpha3 release.

In detail deleted files from following PR's are added:

In addition, this PR here contains also the changes from PR #39684 for the 4.2-dev branch, which are also relevant for 4.3-dev as the corresponding change has been merged up with PR #39681 . @obuisard This will cause a merge conflict at the next upmerge after this PR here has been merged which can be easily solved by using the file from 4.3-dev.

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.3.0-alpha2 or any older 4.x version to the last 4.3 nightly build to get the actual result, and update a 4.3.0-alpha2 or any older 4.x version to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

The files mentioned above are still present after updating from a 4.3.0-alpha2 or any older 4.x version.

Expected result AFTER applying this Pull Request

The files mentioned above have been deleted after updating from a 4.3.0-alpha2 or any older 4.x version.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a64ef8e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39685.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 21, 2023
@obuisard obuisard merged commit 77c1ad6 into joomla:4.3-dev Jan 21, 2023
@obuisard
Copy link
Contributor

Thank you Richard @richard67 for your help with this PR!

@richard67 richard67 deleted the 4.3-dev-deleted-files-and-folders-2023-01-21 branch January 21, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants