-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Workflow Transitions #39325
[4.3] Workflow Transitions #39325
Conversation
Recently there have been several people posting that they don't understand Workflows. I was reviewing my notes from the Workflows presentation I gave this year at JoomlaDay fr and I realised that we can easily remove one area of confusion.
I have tested this item ✅ successfully on cf92a8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325. |
1 similar comment
I have tested this item ✅ successfully on cf92a8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325. |
I did not catch this one in time, but the TransitionField could have been modified to extend GroupediistField rather than ListField, where grouping of options is handled more elegantly and would prevent the hard coding of |
Do you want me to look at updating this pr with that? |
Actually, that would be great! Your code is perfectly valid, but since the core is the reference in terms of coding and use of the API, I would prefer we use the available tools we have. Thank you, Brian! |
will do boss |
Having looked at the code I am going to pass on making the change myself and stick with my pr. Feel free of course to reject it and to submit your own. |
@brianteeman I do not want to close this PR because of the work that you put into it and the user benefits. |
I would prefer it if you did it as a pr to my branch |
Ok, I can do that. |
* Update TransitionField.php Extend Groupedlist rather than List * Update TransitionField.php Removed spaces * Update TransitionField.php Test if items are present before creating a group
This will need you tests |
I have tested this item ✅ successfully on 9cbbc25 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325. |
Jacob @jwaisner, would you mind testing the PR once more as the Transition field has been updated to extend Groupedlist? Thank you very much! |
Vio @viocassel, we need a new test for this updated PR, do you mind re-testing? Thank you! |
I have tested this item ✅ successfully on 9cbbc25 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39325. |
Thank you Brian @brianteeman ! |
thx |
@brianteeman Can you please look into this for the frontend? Thanks. |
Recently there have been several people posting that they don't understand Workflows. I was reviewing my notes from the Workflows presentation I gave this year at JoomlaDay fr and I realised that we can easily remove one area of confusion.
Summary of Changes
Add a title to the options so that it is clear what they are for. It was confusing before because the displayed value is a stage but the options are a transition.
Bizaarely we must have realised this before because the Action button already adds some clarification by saying "Run Transitions"
NOTE: If you are using the workflow from the sample data the problems this PR fixes are more obvious
Testing Instructions
Actual result BEFORE applying this Pull Request
In the list view it is not clear that there are two different things in the list - current stage name and transitions
In the article view it says Workflow but it should say Workflow Stage and it is not clear that there are two different things in the list - current stage name and transitions
Expected result AFTER applying this Pull Request
Article List View
Article Edit View
Link to documentations
Please select:
Documentation link for docs.joomla.org:
screenshots will need updating
No documentation changes for manual.joomla.org needed