Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string interpolation deprectaed in PHP 8.2 #38983

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Oct 17, 2022

Pull Request for Issue #38259.

Summary of Changes

Applied the migration script from the PHP RFC to the repository. This replaces th deprecated ${...} interpolation syntax with a longer-supported one (`{$...}).

Testing Instructions

code review, no functional changes

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Oct 21, 2022
@alikon
Copy link
Contributor

alikon commented Oct 29, 2022

I have tested this item ✅ successfully on 6cb6378


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38983.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6cb6378


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38983.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-4.2-dev labels Nov 6, 2022
@alikon
Copy link
Contributor

alikon commented Nov 6, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38983.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 6, 2022
@alikon alikon added PHP 8.x PHP 8.x deprecated issues PR-4.2-dev labels Nov 6, 2022
@laoneo laoneo merged commit 9cbe6cb into joomla:4.2-dev Nov 9, 2022
@laoneo
Copy link
Member

laoneo commented Nov 9, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 9, 2022
@laoneo laoneo added this to the Joomla! 4.2.6 milestone Nov 9, 2022
@ManuelHu ManuelHu deleted the php82-interpolation branch February 11, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants